Skip to content

Comments

Add end-tags for test tag parser (BSI audit).#2001

Merged
fisx merged 6 commits intodevelopfrom
bsi-tags-23
Dec 16, 2021
Merged

Add end-tags for test tag parser (BSI audit).#2001
fisx merged 6 commits intodevelopfrom
bsi-tags-23

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Dec 16, 2021

https://wearezeta.atlassian.net/browse/SQSERVICES-1128

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@fisx fisx requested a review from mdimjasevic December 16, 2021 12:01
@@ -489,6 +489,8 @@ testRemoveClient hasPwd brig cannon = do
newClientCookie = Just defCookieLabel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot mark the correct line in this file but there is a @END tag missing around line 446

Copy link
Contributor

@mythsunwind mythsunwind Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fisx I see also that in this file there is a space missing between @SF.Channel and @TSFI.RESTfulAPI in the lines before:

  • "rejects saml responses with invalid issuer entity id"
  • "rejects saml responses signed with the wrong private key"
  • "rejects saml responses to requests not in cassandra:spar.authreq"
  • "rejects saml responses already seen (and recorded in cassandra:spar.authresp)"

Additionally please change @SF.CHANNEL into @SF.Channel

@fisx fisx requested a review from mythsunwind December 16, 2021 13:45
@fisx fisx merged commit b50e906 into develop Dec 16, 2021
@fisx fisx deleted the bsi-tags-23 branch December 16, 2021 16:22
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants