Conversation
mdimjasevic
approved these changes
Dec 16, 2021
mythsunwind
reviewed
Dec 16, 2021
| @@ -489,6 +489,8 @@ testRemoveClient hasPwd brig cannon = do | |||
| newClientCookie = Just defCookieLabel | |||
Contributor
There was a problem hiding this comment.
I cannot mark the correct line in this file but there is a @END tag missing around line 446
Contributor
There was a problem hiding this comment.
@fisx I see also that in this file there is a space missing between @SF.Channel and @TSFI.RESTfulAPI in the lines before:
- "rejects saml responses with invalid issuer entity id"
- "rejects saml responses signed with the wrong private key"
- "rejects saml responses to requests not in cassandra:spar.authreq"
- "rejects saml responses already seen (and recorded in cassandra:spar.authresp)"
Additionally please change @SF.CHANNEL into @SF.Channel
mythsunwind
approved these changes
Dec 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1128
Checklist
changelog.d.