Skip to content

Split cannon benchmarks and tests#1986

Merged
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/split-cannon-benchmarks
Dec 15, 2021
Merged

Split cannon benchmarks and tests#1986
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/split-cannon-benchmarks

Conversation

@pcapriotti
Copy link
Contributor

Cannon benchmarks were running as part of the test suite. This creates a separate component for cannon benchmarks, so that they are not run alonside the other unit tests.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@supersven supersven self-requested a review December 14, 2021 06:21
@supersven
Copy link
Contributor

Looks good to me. 👍

Let's wait for the CI results. When they're positive, I'll approve.

@pcapriotti pcapriotti merged commit 70316ac into develop Dec 15, 2021
@pcapriotti pcapriotti deleted the pcapriotti/split-cannon-benchmarks branch December 15, 2021 12:29
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants