Skip to content

Comments

SQSERVICES-1126 Missing Clients (BSI Docs)#1985

Merged
fisx merged 8 commits intodevelopfrom
SQSERVICES-1126-provide-test-cases-for-SF.Separation-for-BSI-2
Dec 14, 2021
Merged

SQSERVICES-1126 Missing Clients (BSI Docs)#1985
fisx merged 8 commits intodevelopfrom
SQSERVICES-1126-provide-test-cases-for-SF.Separation-for-BSI-2

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Dec 13, 2021

This covers list item 2 from this ticket

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann
Copy link
Contributor Author

I tried to make the test as self-explanatory as possible, so that there is no need to write extensive comments.

@battermann
Copy link
Contributor Author

In the ticket it says that the user should get a notification if sending of the message failed. Is there a way to test this, too. Is it necessary at all?

@battermann battermann force-pushed the SQSERVICES-1126-provide-test-cases-for-SF.Separation-for-BSI-2 branch from 5691be5 to 7a07ef6 Compare December 13, 2021 12:13
@fisx
Copy link
Contributor

fisx commented Dec 13, 2021

@mythsunwind FYI. (I'll also make sure the tickets will have all PRs linked by the time we consider ourselves done, then you can take a last look and second-guess me. :))

Leif Battermann and others added 7 commits December 13, 2021 14:09
Co-authored-by: fisx <mf@zerobuzz.net>
Co-authored-by: fisx <mf@zerobuzz.net>
…ses-for-SF.Separation-for-BSI-1

SQSERVICES-1126 Provide test cases for SF.Separation BSI
@fisx
Copy link
Contributor

fisx commented Dec 14, 2021

I merged #1989 and hereby re-approve. I think just tried locally, and I think this can be merged independently of #1869 in any order.

@fisx fisx merged commit 5ace595 into develop Dec 14, 2021
@fisx fisx deleted the SQSERVICES-1126-provide-test-cases-for-SF.Separation-for-BSI-2 branch December 14, 2021 12:28
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants