Skip to content

Comments

Do not purge bucket in fake-s3#1981

Merged
pcapriotti merged 2 commits intodevelopfrom
pcapriotti/fix-cargohold-flake
Dec 13, 2021
Merged

Do not purge bucket in fake-s3#1981
pcapriotti merged 2 commits intodevelopfrom
pcapriotti/fix-cargohold-flake

Conversation

@pcapriotti
Copy link
Contributor

With purge: true the reaper script will delete the bucket's content when it runs, causing integration tests to fail occasionally.

This fixes a very frequent flake in CI integration tests (e.g. https://bridge-ie-concourse.zinfra.io/builds/21651258).

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

With `purge: true` the reaper script will delete the bucket's content
when it runs, causing integration tests to fail occasionally.

This fixes a very frequent flake in CI integration tests (e.g.
https://bridge-ie-concourse.zinfra.io/builds/21651258).
@pcapriotti pcapriotti merged commit 262b7c2 into develop Dec 13, 2021
@pcapriotti pcapriotti deleted the pcapriotti/fix-cargohold-flake branch December 13, 2021 10:57
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants