Skip to content

Comments

SQSERVICES-547 add feature config for guest links#1964

Merged
battermann merged 18 commits intodevelopfrom
SQSERVICES-547-add-feature-config-for-guest-links
Dec 9, 2021
Merged

SQSERVICES-547 add feature config for guest links#1964
battermann merged 18 commits intodevelopfrom
SQSERVICES-547-add-feature-config-for-guest-links

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Dec 3, 2021

Implementation for https://wearezeta.atlassian.net/browse/SQSERVICES-1045 and https://wearezeta.atlassian.net/browse/SQSERVICES-1046 for Epic

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch 2 times, most recently from 6c31ad6 to caee421 Compare December 3, 2021 16:45
@battermann battermann requested a review from fisx December 3, 2021 16:46
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch from 6cf1006 to 169d893 Compare December 6, 2021 08:01
@battermann battermann changed the title SQSERVICES-547 add feature config for guest links SQSERVICES-547 add feature config for guest links [skip ci] Dec 6, 2021
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch 3 times, most recently from ecd3c24 to 9891eba Compare December 6, 2021 11:08
@battermann battermann changed the title SQSERVICES-547 add feature config for guest links [skip ci] SQSERVICES-547 add feature config for guest links Dec 7, 2021
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch from 45327a1 to cbf5319 Compare December 7, 2021 12:52
@battermann battermann marked this pull request as ready for review December 7, 2021 12:53
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch from 1fa7af1 to 5ae967a Compare December 8, 2021 08:10
@fisx
Copy link
Contributor

fisx commented Dec 8, 2021

last ci failure looks like a flake:

brig                             >     sftDiscoveryLoop
brig                             >       when service can be discovered:                                 OK
brig                             >       when service can be discovered and the URLs change:             FAIL
brig                             >         test/unit/Test/Brig/Calling.hs:169:
brig                             >         servers should get overwritten
brig                             >         expected: Discovered (SFTServers (SrvEntry {srvPriority = 0, srvWeight = 0, srvTarget = SrvTarget {srvTargetDomain = "sft4.foo.example.com.", srvTargetPort = 443}} :| [SrvEntry {srvPriority = 0, srvWeight = 0, srvTarget = SrvTarget {srvTargetDomain = "sft5.foo.example.com.", srvTargetPort = 443}}]))
brig                             >          but got: Discovered (SFTServers (SrvEntry {srvPriority = 0, srvWeight = 0, srvTarget = SrvTarget {srvTargetDomain = "sft1.foo.example.com.", srvTargetPort = 443}} :| [SrvEntry {srvPriority = 0, srvWeight = 0, srvTarget = SrvTarget {srvTargetDomain = "sft2.foo.example.com.", srvTargetPort = 443}},SrvEntry {srvPriority = 0, srvWeight = 0, srvTarget = SrvTarget {srvTargetDomain = "sft3.foo.example.com.", srvTargetPort = 443}}]))

but i also forgot to push something important. it's now there.

@fisx
Copy link
Contributor

fisx commented Dec 8, 2021

today's not a good day for concourse....

@fisx fisx mentioned this pull request Dec 8, 2021
2 tasks
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch from 5c867e4 to 7fd8eb2 Compare December 9, 2021 10:22
@battermann battermann merged commit 1829258 into develop Dec 9, 2021
@battermann battermann deleted the SQSERVICES-547-add-feature-config-for-guest-links branch December 9, 2021 11:42
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants