Skip to content

Comments

Correctly detect log level when rendering logs as structured JSON#1959

Merged
akshaymankar merged 1 commit intodevelopfrom
akshaymankar/structured-json-level
Dec 6, 2021
Merged

Correctly detect log level when rendering logs as structured JSON#1959
akshaymankar merged 1 commit intodevelopfrom
akshaymankar/structured-json-level

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Dec 2, 2021 •
edited
Loading

Fix for #1951 (comment)

https://wearezeta.atlassian.net/browse/FS-62

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@akshaymankar akshaymankar force-pushed the akshaymankar/structured-json-level branch from f2a29d8 to a60bdc7 Compare December 2, 2021 16:20
@akshaymankar akshaymankar force-pushed the akshaymankar/structured-json-level branch from a60bdc7 to 2f08869 Compare December 6, 2021 08:28
@akshaymankar akshaymankar merged commit 916d33b into develop Dec 6, 2021
@akshaymankar akshaymankar deleted the akshaymankar/structured-json-level branch December 6, 2021 13:00
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Merged
jschaul added a commit that referenced this pull request Jul 13, 2022
@jschaul
charts/*: default logFormat=StructuredJSON format
67e8ae8 
This format was introduced in #1951 and #1959.
@jschaul jschaul mentioned this pull request Jul 13, 2022
Merged
3 tasks
jschaul added a commit that referenced this pull request Jul 14, 2022
@jschaul @akshaymankar
charts/*: default logFormat=StructuredJSON format (#2559)
986da6f 
* charts/*: default logFormat=StructuredJSON format

This format was introduced in #1951 and #1959.

* Hi CI

* spar: Ensure integration test for testing logging works with StructuredJSON logs

Co-authored-by: Akshay Mankar <akshay@wire.com>
@zebot zebot mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smatting smatting smatting approved these changes

@jschaul jschaul Awaiting requested review from jschaul

@fisx fisx Awaiting requested review from fisx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaymankar @smatting