Handle Galley errors in federation RPCs#1928
Merged
pcapriotti merged 4 commits intodevelopfrom Nov 17, 2021
Merged
Conversation
pcapriotti
changed the base branch from
develop
to
pcapriotti/galley-polysemy-cleanup
Base automatically changed from
pcapriotti/galley-polysemy-cleanup
to
develop
November 16, 2021 13:14
pcapriotti
force-pushed
the
pcapriotti/galley-federation-errors
branch
2 times, most recently
from
c585f86 to
c8cc1dd
Compare
mdimjasevic
approved these changes
Nov 17, 2021
Contributor
There was a problem hiding this comment.
Shouldn't the last part of the test description be about being denied instead of non-existent?
Return errors as part of the response of the leave-conversation RPC. This commit also simplifies the response type considerably, by limiting constructors to one per possible error type. It also replaces error responses in the public API handler with `CanThrow`.
pcapriotti
force-pushed
the
pcapriotti/galley-federation-errors
branch
from
c8cc1dd to
b663778
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors when leaving a conversation are now correctly handled instead of resulting in a generic federation error.
Tracked by https://wearezeta.atlassian.net/browse/FS-40.
Checklist
changelog.d.