Skip to content

Comments

Faktor out golden tests into separate test suite in wire-api.#1926

Merged
fisx merged 1 commit intodevelopfrom
separate-golden-tests
Nov 15, 2021
Merged

Faktor out golden tests into separate test suite in wire-api.#1926
fisx merged 1 commit intodevelopfrom
separate-golden-tests

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Nov 12, 2021

This pulls the combined test suite in wire-api apart and makes it two suites that can be run and compiled separately to save time. To get the previous experience:

stack test --fast wire-api

To only run (and, more importantly, compile) the test suite that you need:

stack test --fast wire-api:wire-api-tests
stack test --fast wire-api:wire-api-golden-tests

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@fisx
Copy link
Contributor Author

fisx commented Nov 12, 2021

I think cabal test wire-api:wire-api-tests also does the trick.

Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisx fisx merged commit 8ecea4d into develop Nov 15, 2021
@fisx fisx deleted the separate-golden-tests branch November 15, 2021 11:54
@akshaymankar akshaymankar mentioned this pull request Nov 15, 2021
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants