Skip to content

Comments

Spar Polysemy: Split VerdictFormatStore from AReqIdStore#1925

Merged
isovector merged 5 commits intodevelopfrom
split-eff2
Nov 16, 2021
Merged

Spar Polysemy: Split VerdictFormatStore from AReqIdStore#1925
isovector merged 5 commits intodevelopfrom
split-eff2

Conversation

@isovector
Copy link
Contributor

@isovector isovector commented Nov 11, 2021

This PR splits VerdictFormatStore from the AReqIdStore effect, which was accidentally paired together when I was separating effects.

Also did some related cleanup around orphan instances.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Also did some related cleanup around orphan instances
@isovector isovector requested a review from fisx November 11, 2021 05:20
@isovector isovector merged commit 452c4de into develop Nov 16, 2021
@isovector isovector deleted the split-eff2 branch November 16, 2021 01:18
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants