Do not fail user deletion when a remote notification fails#1912
Merged
Do not fail user deletion when a remote notification fails#1912
Conversation
smatting
force-pushed
the
FS-124-user-deletion-nonavail-remotes
branch
from
60a843d to
6991453
Compare
mdimjasevic
approved these changes
Nov 9, 2021
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
This looks good. A few smaller comments are left inlined.
services/brig/src/Brig/IO/Intra.hs
Outdated
Comment on lines
278
to
281
| case eitherFErr of | ||
| Left fErr -> do | ||
| logFederationError (tDomain uids) fErr | ||
| -- FUTUTREWORK: Do something better here? | ||
| -- FUTUREWORK: Write test that this happens | ||
| throwM $ federationErrorToWai fErr | ||
| Right () -> pure () |
Contributor
There was a problem hiding this comment.
A pattern like this is encapsulated by whenLeft :: Applicative m => Either a b -> (a -> m ()) -> m ().
Comment on lines
1284
to
1288
| case (requestMethod, requestPath) of | ||
| (_methodDelete, ["i", "user"]) -> do | ||
| let response = Wai.responseLBS Http.status200 [(Http.hContentType, "application/json")] (cs $ Aeson.encode EmptyResponse) | ||
| pure response | ||
| _ -> error "not mocked" |
Contributor
There was a problem hiding this comment.
There's no need to pattern match on requestMethod as it is vacuous, right?
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. I changed this to a proper pattern match in d92e7fa
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
https://wearezeta.atlassian.net/browse/FS-124
changelog.d.