Galley polysemy (4/5) - Error effects

changelog.d/5-internal/polysemy-errors

@@ -0,0 +1 @@
+Introduce fine-grained error types and polysemy error effects in Galley.

libs/wire-api-federation/src/Wire/API/Federation/Client.hs

@@ -127,6 +127,7 @@ data FederationError
   | FederationNotImplemented
   | FederationNotConfigured
   | FederationCallFailure FederationClientFailure
+  | FederationUnexpectedBody Text
   deriving (Show, Eq, Typeable)
 
 instance Exception FederationError

libs/wire-api-federation/src/Wire/API/Federation/Error.hs

@@ -76,6 +76,7 @@ federationErrorToWai (FederationCallFailure failure) = addErrorData $
                   Wai.federrPath = T.decodeUtf8 (fedFailPath failure)
                 }
         }
+federationErrorToWai (FederationUnexpectedBody s) = federationUnexpectedBody s
 
 noFederationStatus :: Status
 noFederationStatus = status403

libs/wire-api/src/Wire/API/Conversation/Action.hs

@@ -34,8 +34,7 @@ import Wire.API.Conversation.Role
 import Wire.API.Event.Conversation
 import Wire.API.Util.Aeson (CustomEncoded (..))
 
--- | An update to a conversation, including addition and removal of members.
--- Used to send notifications to users and to remote backends.
+-- | A sum type consisting of all possible conversation actions.
 data ConversationAction
   = ConversationActionAddMembers (NonEmpty (Qualified UserId)) RoleName
   | ConversationActionRemoveMembers (NonEmpty (Qualified UserId))

libs/wire-api/src/Wire/API/ErrorDescription.hs

@@ -226,10 +226,13 @@ noIdentity n = ErrorDescription (Text.pack (symbolVal (Proxy @desc)) <> " (code
 
 type OperationDenied = ErrorDescription 403 "operation-denied" "Insufficient permissions"
 
-operationDenied :: Show perm => perm -> OperationDenied
-operationDenied p =
+operationDeniedSpecialized :: String -> OperationDenied
+operationDeniedSpecialized p =
   ErrorDescription $
-    "Insufficient permissions (missing " <> Text.pack (show p) <> ")"
+    "Insufficient permissions (missing " <> Text.pack p <> ")"
+
+operationDenied :: Show perm => perm -> OperationDenied
+operationDenied = operationDeniedSpecialized . show
 
 type NotATeamMember = ErrorDescription 403 "no-team-member" "Requesting user is not a team member"
 

services/galley/galley.cabal

@@ -4,7 +4,7 @@ cabal-version: 1.12
 --
 -- see: https://github.com/sol/hpack
 --
--- hash: 7c30fbe05e0beac371abdaab802319d909686c98a1b133508c984e021b2999ba
+-- hash: 6f378c75d7938aa5f221f136049c8ca98f63e7ae682e0035fb912f3917cfd1b1
 
 name:           galley
 version:        0.83.0
@@ -25,6 +25,7 @@ flag static
 library
   exposed-modules:
       Galley.API
+      Galley.API.Action
       Galley.API.Clients
       Galley.API.Create
       Galley.API.CustomBackend