Conversation
jschaul
commented
Nov 3, 2021
| parseAWSEndpoint :: ReadM AWSEndpoint | ||
| parseAWSEndpoint = readerAsk >>= maybe (error "Could not parse AWS endpoint") return . fromByteString . fromString | ||
|
|
||
| cassandraParser :: Parser CassandraOpts |
Member
Author
There was a problem hiding this comment.
This was dead code not used anywhere.
akshaymankar
approved these changes
Nov 10, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://wearezeta.atlassian.net/browse/BM-14 and related PR https://github.com/zinfra/cailleach/pull/703
Example: galley/gundeck don't configure this option, spar configures a valid datacentre, brig configures an invalid datacentre:
So the behaviour is:
Checklist
changelog.d.