Close GRPC client after making a request to federator#1873
Merged
pcapriotti merged 3 commits intodevelopfrom Nov 4, 2021
Merged
Close GRPC client after making a request to federator#1873pcapriotti merged 3 commits intodevelopfrom
pcapriotti merged 3 commits intodevelopfrom
Conversation
akshaymankar
approved these changes
Oct 21, 2021
pcapriotti
force-pushed
the
pcapriotti/close-more-grpc-clients
branch
from
b2ce32d to
2792505
Compare
pcapriotti
changed the base branch from
develop
to
pcapriotti/galley-placeholders
pcapriotti
force-pushed
the
pcapriotti/galley-placeholders
branch
from
31db8b3 to
e56a756
Compare
pcapriotti
force-pushed
the
pcapriotti/close-more-grpc-clients
branch
from
2792505 to
55494ef
Compare
jschaul
approved these changes
Nov 3, 2021
Also abstract the function that closes a GRPC client, and make it ignore errors.
pcapriotti
force-pushed
the
pcapriotti/close-more-grpc-clients
branch
from
55494ef to
b21bcd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup PR to #1865, addressing the same issue, but for GRPC connections to the internal federator. This also takes care of cleaning of the GrpcClient in tests.
Checklist
changelog.d.