Avoid linear lookup when checking new members#1845
Merged
pcapriotti merged 1 commit intodevelopfrom Dec 7, 2021
Merged
Conversation
mdimjasevic
approved these changes
Nov 4, 2021
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Oh, I forgot about this one! It looks to me like it'll need conflict resolving due to the Polysemy effect changes to Galley.
pcapriotti
force-pushed
the
pcapriotti/cleanup-check-locals
branch
from
e04e695 to
7cafbc0
Compare
pcapriotti
force-pushed
the
pcapriotti/cleanup-check-locals
branch
from
742b451 to
1d0f47a
Compare
pcapriotti
force-pushed
the
pcapriotti/cleanup-check-locals
branch
from
1d0f47a to
b7153e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small refactoring to avoid quadratic runtime building a user team membership map when adding new members to a conversation.
No CHANGELOG entry.
Checklist