Skip to content

fix flaky test by waiting for user deletion to finish#1760

Merged
fisx merged 1 commit intodevelopfrom
fix-flaky-spar-test
Sep 13, 2021
Merged

fix flaky test by waiting for user deletion to finish#1760
fisx merged 1 commit intodevelopfrom
fix-flaky-spar-test

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented Sep 13, 2021

Possible fix for flaky test as described in https://wearezeta.atlassian.net/browse/SQSERVICES-780

Failures:
  test-integration/Test/Spar/APISpec.hs:1159:17: 
  
  1) Spar.API, delete corner cases, re-create previously deleted, dangling users

       "<?xml version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\" \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\"><html xml:lang=\"en\" xmlns=\"http://www.w3.org/1999/xhtml\"><head>  <title>wire:sso:error:unknown-error</title>   <script type=\"text/javascript\">       const receiverOrigin = '*';       window.opener.postMessage({\"payload\":{\"errors\":[\"invalid-credentials {\\\"code\\\":403,\\\"message\\\":\\\"Authentication failed.\\\",\\\"label\\\":\\\"invalid-credentials\\\"}\"],\"label\":\"forbidden\"},\"type\":\"AUTH_ERROR\"}, receiverOrigin);   </script></head></html>" does not contain "<title>wire:sso:success</title>"

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@jschaul jschaul requested a review from fisx September 13, 2021 20:41
@jschaul
Copy link
Member Author

jschaul commented Sep 13, 2021

Flaky test was seen in CI for #1758 (the commit before HI CI)

fisx
fisx approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks plausible that this would resolve the issue, and I'm pretty sure the change doesn't break anything.

@fisx fisx merged commit 2697ad0 into develop Sep 13, 2021
@fisx fisx deleted the fix-flaky-spar-test branch September 13, 2021 21:52
@jschaul jschaul mentioned this pull request Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisx fisx fisx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jschaul @fisx