Remove self role updates#1752
Merged
pcapriotti merged 3 commits intopcapriotti/remove-muted-fieldfrom Sep 13, 2021
Merged
Conversation
Updates to a member's role now always happen via `OtherMemberUpdate`, while `MemberUpdate` is used to change conversation self status (i.e. hidden/muted/archived).
This was a newly added qualified endpoint stub, which raised an error when used on a remote conversation. We are now deprecating fetching conversation self membership information altogether (since clients do not use it, and they can always get that information from the conversation itself), so this endpoint can simply be removed.
5 tasks
akshaymankar
approved these changes
Sep 13, 2021
pcapriotti
added a commit
that referenced
this pull request
Sep 13, 2021
* Removed mupConvRoleName and self role updates Updates to a member's role now always happen via `OtherMemberUpdate`, while `MemberUpdate` is used to change conversation self status (i.e. hidden/muted/archived). * Remove qualified GET conversation self This was a newly added qualified endpoint stub, which raised an error when used on a remote conversation. We are now deprecating fetching conversation self membership information altogether (since clients do not use it, and they can always get that information from the conversation itself), so this endpoint can simply be removed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to a member's role now always happen via
OtherMemberUpdate, whileMemberUpdateis only used to change conversation self status (i.e. hidden/muted/archived).Also remove the newly added qualified endpoint for fetching self membership data. It was not implemented for remote conversations, and it is not going to be, since the role will not even be stored remotely.
Checklist
changelog.d.