Skip to content

Comments

Increase federator monitor test timeout to 10s#1750

Merged
pcapriotti merged 1 commit intodevelopfrom
pcapriotti/fed-cert-test-timeout
Sep 10, 2021
Merged

Increase federator monitor test timeout to 10s#1750
pcapriotti merged 1 commit intodevelopfrom
pcapriotti/fed-cert-test-timeout

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 9, 2021

Apparently, 1 second is not enough in CI.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti force-pushed the pcapriotti/fed-cert-test-timeout branch from b739468 to b8919f0 Compare September 10, 2021 05:38
@pcapriotti pcapriotti marked this pull request as ready for review September 10, 2021 05:39
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we used types for time units to avoid all kinds of time conversion errors.

@pcapriotti pcapriotti merged commit de673a6 into develop Sep 10, 2021
@pcapriotti pcapriotti deleted the pcapriotti/fed-cert-test-timeout branch September 10, 2021 07:12
@jschaul jschaul mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants