Ensure clients only receive messages meant for them in remote convs#1739
Merged
akshaymankar merged 7 commits intodevelopfrom Sep 8, 2021
Merged
Conversation
akshaymankar
commented
Sep 7, 2021
pcapriotti
reviewed
Sep 7, 2021
This commit removes duplicated logic to push messages to clients by making logic in Galley.API.Message.sendLocalMessages accomodating to pushing messages for remote conversations, but still enforcing the recipients to be local. Using this function from federation endpoint of galley allows us to not duplicate the logic for how a message becomes an event and gets pushed to each client. The commit also moves this logic from Galley.API.Update to Galley.API.Federation as most of the logic to translate from inputs of the federation endpoint to inputs for Galley.API.Message.sendLocalMessages is very federation specific and doesn't need to live in the public API module.
d0d800c to
591cd33
Compare
pcapriotti
approved these changes
Sep 8, 2021
Contributor
pcapriotti
left a comment
There was a problem hiding this comment.
There were some FUTUREWORK merge mishaps, for which I added suggestions. Looks good otherwise.
Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
akshaymankar
added a commit
that referenced
this pull request
Sep 9, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated logic to push messages to clients by making logic
in Galley.API.Message.sendLocalMessages accomodating to pushing messages for
remote conversations, but still enforcing the recipients to be local. Using this
function from federation endpoint of galley allows us to not duplicate the logic
for how a message becomes an event and gets pushed to each client.
The PR also moves this logic from Galley.API.Update to Galley.API.Federation
as most of the logic to translate from inputs of the federation endpoint to
inputs for Galley.API.Message.sendLocalMessages is very federation specific and
doesn't need to live in the public API module.
Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.