Skip to content

Comments

Clean up JSON Golden Tests in wire-api, Part #3#1733

Merged
jschaul merged 105 commits intodevelopfrom
mdimjasevic/reduce-golden-tests-part-3
Sep 7, 2021
Merged

Clean up JSON Golden Tests in wire-api, Part #3#1733
jschaul merged 105 commits intodevelopfrom
mdimjasevic/reduce-golden-tests-part-3

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Sep 2, 2021

This is the third PR in a series of PRs that clean up automatically generated JSON golden tests in wire-api.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

Marko Dimjašević added 30 commits August 31, 2021 10:30
Marko Dimjašević added 23 commits September 2, 2021 13:49
- The only cosmetic change is to remove redundant brackets
…ireapp/wire-server into mdimjasevic/reduce-golden-tests-part-3
@jschaul jschaul merged commit 12dc909 into develop Sep 7, 2021
@jschaul jschaul deleted the mdimjasevic/reduce-golden-tests-part-3 branch September 7, 2021 18:09
@akshaymankar akshaymankar mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants