Skip to content

Avoid remote calls to get conversation when it is not found locally#1723

Merged
akshaymankar merged 4 commits intodevelopfrom
akshaymankar/get-remote-conv-fix
Sep 9, 2021
Merged

Avoid remote calls to get conversation when it is not found locally#1723
akshaymankar merged 4 commits intodevelopfrom
akshaymankar/get-remote-conv-fix

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Aug 30, 2021 •
edited
Loading

Depends on #1703
Re-work of #1713

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@akshaymankar akshaymankar force-pushed the akshaymankar/get-remote-conv-fix branch from 9493842 to c070df9 Compare September 9, 2021 07:53
@akshaymankar akshaymankar marked this pull request as ready for review September 9, 2021 07:53
pcapriotti
pcapriotti reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a compile error.

pcapriotti
pcapriotti approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@akshaymankar akshaymankar merged commit eae4880 into develop Sep 9, 2021
@akshaymankar akshaymankar deleted the akshaymankar/get-remote-conv-fix branch September 9, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaymankar @pcapriotti