[Federation] Add an Endpoint for Conversation Member Removal based on Qualified User ID#1697

Merged

mdimjasevic merged 125 commits intodevelopfrom

mdimjasevic/mdimjasevic/fed-leave-remote-conv

Aug 27, 2021

Commits on Aug 19, 2021

Make conversation ID qualified in removing a member

Marko Dimjašević
authored and
akshaymankar
committed
Make the ID of the user to be removed from a conversation qualified

Marko Dimjašević
authored and
akshaymankar
committed
Simple renaming and refactoring towards qualified conv leaving

Marko Dimjašević
authored and
akshaymankar
committed
Introduce signatures for two local functions

Marko Dimjašević
authored and
akshaymankar
committed
Migrate DELETE /conversations/:cnv/members/:usr to Servant

Marko Dimjašević
authored and
akshaymankar
committed
HLS improvements

Marko Dimjašević
authored and
akshaymankar
committed
Fix compilation issues and remove an unused handler

Marko Dimjašević
authored and
akshaymankar
committed
Renaming of unqualified conversation tests

Marko Dimjašević
authored and
akshaymankar
committed
Introduce the main endpoint and a test for the local domain case only

Marko Dimjašević
authored and
akshaymankar
committed
Apply eta reduction suggested by HLS

Marko Dimjašević
authored and
akshaymankar
committed
Add a federation gRPC endpoint and a stub handler

Marko Dimjašević
authored and
akshaymankar
committed
WIP: a test for removing members from a a non-existing conversation

Marko Dimjašević
authored and
akshaymankar
committed
Fix up response types and remove unfinished federation tests

Marko Dimjašević
authored and
akshaymankar
committed
Unqualify the conversation ID

Marko Dimjašević
authored and
akshaymankar
committed
Update a test for local conversations

Marko Dimjašević
authored and
akshaymankar
committed
Use ExceptT in removeMemberFromLocalConv

Marko Dimjašević
authored and
akshaymankar
committed
Fix a compilation error after merging

Marko Dimjašević
authored and
akshaymankar
committed
Minor polishing

Marko Dimjašević
authored and
akshaymankar
committed
Generalize a Galley integration test utility

Marko Dimjašević
authored and
akshaymankar
committed
Function renaming to better reflect their purpose

Marko Dimjašević
authored and
akshaymankar
committed
Binding renaming to better reflect what it contains

Marko Dimjašević
authored and
akshaymankar
committed
Add a member removal utility function for remote backends

Marko Dimjašević
authored and
akshaymankar
committed
Notify remote backends of conversation members removed

Marko Dimjašević
authored and
akshaymankar
committed
Add a HasCallStack constraint to an integration test utility

Marko Dimjašević
authored and
akshaymankar
committed
Update the changelog with the deprecated endpoint

Marko Dimjašević
authored and
akshaymankar
committed
Introduce a conversation event type for removing qualified members

Marko Dimjašević
authored and
akshaymankar
committed
A conversation membership update can either add or remove users

Marko Dimjašević
authored and
akshaymankar
committed
Backwards compatibility: return the MemberLeave Event type

Marko Dimjašević
authored and
akshaymankar
committed
Add a federated test for a conversation membership update

Marko Dimjašević
authored and
akshaymankar
committed
Membership handler: pull out common parts from distinct cases

Marko Dimjašević
authored and
akshaymankar
committed
Fix a couple of small documentation errors

Marko Dimjašević
authored and
akshaymankar
committed
There must be at least 1 member in a conversation membership update

Marko Dimjašević
authored and
akshaymankar
committed
Use the right backwards compatibility flag in an old endpoint handler

Marko Dimjašević
authored and
akshaymankar
committed
Fix the usage of randomUser in federation tests

Marko Dimjašević
authored and
akshaymankar
committed
Update a federation test description

Marko Dimjašević
authored and
akshaymankar
committed
Update a comment next to the qualified endpoint for member removal

Marko Dimjašević
authored and
akshaymankar
committed
Make two more errors explicit in the type of Update.removeMember

Marko Dimjašević
authored and
akshaymankar
committed
Minor documentation improvement and removing commented out code

Marko Dimjašević
authored and
akshaymankar
committed
Finish expressing the errors of Update.removeMember via its type

Marko Dimjašević
authored and
akshaymankar
committed
Remove unneeded class instances

Marko Dimjašević
authored and
akshaymankar
committed
Remove an unused type constraint on a test utility

Marko Dimjašević
authored and
akshaymankar
committed
Add an integration test for removing a local user

Marko Dimjašević
authored and
akshaymankar
committed
Update the change log

Marko Dimjašević
authored and
akshaymankar
committed
Add documentation for the ConversationMembersAction type

Marko Dimjašević
authored and
akshaymankar
committed
Fix the documentation of a module

Marko Dimjašević
authored and
akshaymankar
committed
Update the description of a federation test

Marko Dimjašević
authored and
akshaymankar
committed
Move the non-empty list with origin type to an appropriate module

Marko Dimjašević
authored and
akshaymankar
committed
Fix a typo

Marko Dimjašević
authored and
akshaymankar
committed
Make deprecatedSchema more general

Marko Dimjašević
authored and
akshaymankar
committed
Make UserIdList take a list of qualified user IDs

Marko Dimjašević
authored and
akshaymankar
committed
Remove the MemberLeaveQualified conversation event type

Marko Dimjašević
authored and
akshaymankar
committed
Remove the even backwards compatibility flag

Marko Dimjašević
authored and
akshaymankar
committed
The removal endpoint takes a qualified conversation ID

Marko Dimjašević
authored and
akshaymankar
committed
Introduce several integration test utilities

Marko Dimjašević
authored and
akshaymankar
committed
Avoid repeating: use an integration test utility

Marko Dimjašević
authored and
akshaymankar
committed
Add a currently failing test

Marko Dimjašević
authored and
akshaymankar
committed
Update an endpoint comment

Marko Dimjašević
authored and
akshaymankar
committed
Add a Haddock for Update.removeMember

Marko Dimjašević
authored and
akshaymankar
committed
Make sure remote conversation members can't remove others

Marko Dimjašević
authored and
akshaymankar
committed
Change a function input type so it is constrained in usage

Marko Dimjašević
authored and
akshaymankar
committed
Add documentation for a function's arguments

Marko Dimjašević
authored and
akshaymankar
committed
Generalize a few Galley member utilities

Marko Dimjašević
authored and
akshaymankar
committed
Further generalize conversation member utilities

Marko Dimjašević
authored and
akshaymankar
committed
Make remover qualified in Update.removeMember

Marko Dimjašević
authored and
akshaymankar
committed
Add an endpoint: DELETE /federation/leave-conversation

Marko Dimjašević
authored and
akshaymankar
committed
A minor readability improvement

Marko Dimjašević
authored and
akshaymankar
committed
Finish implementing the leaving of a remote conversation

Marko Dimjašević
authored and
akshaymankar
committed
Fix a typo in the documentation

Marko Dimjašević
authored and
akshaymankar
committed
Get rid of the QualifiedUserIdList type

Marko Dimjašević
authored and
akshaymankar
committed
Change a TODO into a FUTUREWORK

Marko Dimjašević
authored and
akshaymankar
committed
Reuse a testing utility instead of writing it from scratch

Marko Dimjašević
authored and
akshaymankar
committed
Fix compile errors after rebase
akshaymankar
committed

Commits on Aug 23, 2021

Ormolu
akshaymankar
committed
Fix the JSON instances for team events
Marko Dimjašević
committed
Rename a field of the ConversationMemberUpdate record
Marko Dimjašević
committed
Redo removing a leftover
Marko Dimjašević
committed
Update services/galley/src/Galley/API/Util.hs

Marko Dimjašević
and
akshaymankar
authored

Commits on Aug 24, 2021

Simplify responses for conversation member removal
Marko Dimjašević
committed
Get rid of a special case for leaving a conversation
Marko Dimjašević
committed
Use only POST and HTTP 200 in federation api for leaving conv
Marko Dimjašević
committed
Make swagger prettier for multiple qualified captures
Marko Dimjašević
committed
removeMembersFromLocalConv: Delete function
Marko Dimjašević
committed
addToConversaion: Accept two simple lists
Marko Dimjašević
committed
Improve Haddock of a function
Marko Dimjašević
committed
Use NonEmpty in ConversationMemberAction
Marko Dimjašević
committed
Delete List1WithOrigin
Marko Dimjašević
committed
Use unless to have less indentation
Marko Dimjašević
committed
Simplify removeMemberFromLocalConv
Marko Dimjašević
committed
Fix an integration test
Marko Dimjašević
committed
Add a golden test for /federation/leave-conversation
Marko Dimjašević
committed
Add a few golden tests for ConversationMemberUpdate
Marko Dimjašević
committed

Commits on Aug 25, 2021

Commits on Aug 26, 2021