helm mapkubeapis plugin - also in offline packages#600
Merged
Conversation
jschaul
requested review from
akshaymankar,
julialongtin,
supersven and
sysvinit
supersven
approved these changes
Jan 26, 2023
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
Overall, LGTM 👍
I've left one comment. Solving it might make the code easier to digest.
| @@ -1,4 +1,7 @@ | |||
| self: super: { | |||
| self: | |||
| let helm-mapkubeapis = self.callPackage ./pkgs/helm-mapkubeapis.nix { }; | |||
Contributor
There was a problem hiding this comment.
I was a bit surprised seeing this expression here.
Have you tried to move it closer to its usage? E.g. to line 16?
Member
Author
There was a problem hiding this comment.
I did. But then it gave me "variable helm-mapkubeapis unknown" or something similar. When I moved it up here it worked.
Contributor
There was a problem hiding this comment.
It's not that bad. So, never mind 🤷 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also wireapp/wire-server#3019 and https://github.com/zinfra/cailleach/pull/1502