Feat: Generate QR codes via teams API (SQPIT-1369)#586
Merged
Conversation
This is more convenient (and, hopefully more stable) than relying on database schemas and access.
94325a1 to
0970518
Compare
Contributor
Author
|
This can be merged after wireapp/wire-server#2684 has been released. One open question is, if we want to keep the old version (using Cassandra), too. In case, we could easily restore it. |
a5f3ffb to
fe691b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more convenient (and, hopefully more stable) than relying on database schemas and access.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Solves https://wearezeta.atlassian.net/browse/SQPIT-1369
Solutions
I've adjusted the existing script that queried the database to query Wire's teams API.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
GitHub link to other pull requestTesting
Test Coverage (Optional)
I have added automated test to this contributionHow to Test
Run this
and scan (and check) the result codes of the created PDF file.
Please ask me for the correct values of
NGINZ_HOSTandDEEPLINK_URL. (The values provided here won't work.)PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.