Skip to content

Comments

Feat: Generate QR codes via teams API (SQPIT-1369)#586

Merged
supersven merged 2 commits intomasterfrom
sventennie/qr-codes-via-teams-api
Sep 28, 2022
Merged

Feat: Generate QR codes via teams API (SQPIT-1369)#586
supersven merged 2 commits intomasterfrom
sventennie/qr-codes-via-teams-api

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Sep 16, 2022

This is more convenient (and, hopefully more stable) than relying on database schemas and access.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Solves https://wearezeta.atlassian.net/browse/SQPIT-1369

Solutions

I've adjusted the existing script that queried the database to query Wire's teams API.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Run this

nix-shell -p qrencode texlive.combined.scheme-medium

export TEAM_ADMIN_EMAIL="gCkzC3AP@example.com"
export TEAM_ADMIN_PASSWORD="tIFfm5Hw"
export TEAM_ID="9cabf984-7a35-4cd5-9891-850c64f9195a"
export NGINZ_HOST="nginz-https.wire.example.com"
export DEEPLINK_URL="https://assets.wire.example.com/public/deeplink.html"
export INSTRUCTIONS=./instructions.txt

./generate-user-pdf.sh some-email-you-make-up@example.com

and scan (and check) the result codes of the created PDF file.

Please ask me for the correct values of NGINZ_HOST and DEEPLINK_URL. (The values provided here won't work.)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

This is more convenient (and, hopefully more stable) than relying on
database schemas and access.
@supersven supersven force-pushed the sventennie/qr-codes-via-teams-api branch from 94325a1 to 0970518 Compare September 16, 2022 17:26
@supersven supersven changed the title Generate QR codes via teams API (SQPIT-1369) Feat: Generate QR codes via teams API (SQPIT-1369) Sep 16, 2022
Copy link
Contributor

@arthurwolf arthurwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@supersven
Copy link
Contributor Author

This can be merged after wireapp/wire-server#2684 has been released.

One open question is, if we want to keep the old version (using Cassandra), too. In case, we could easily restore it.

@supersven supersven force-pushed the sventennie/qr-codes-via-teams-api branch from a5f3ffb to fe691b0 Compare September 19, 2022 08:34
@supersven supersven merged commit c2c6a77 into master Sep 28, 2022
@supersven supersven deleted the sventennie/qr-codes-via-teams-api branch September 28, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants