-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New export backup UI - WPB-15211 #2339
Merged
caldrian
merged 51 commits into
epic/prepare-for-universal-backups-WPB-14616
from
feat/new-backup-export-UI-WPB-15211
Jan 14, 2025
Merged
feat: New export backup UI - WPB-15211 #2339
caldrian
merged 51 commits into
epic/prepare-for-universal-backups-WPB-14616
from
feat/new-backup-export-UI-WPB-15211
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files 13 suites 8m 48s ⏱️ Results for commit 1e134af. ♻️ This comment has been updated with latest results. |
caldrian
reviewed
Jan 7, 2025
WireUI/Sources/WireSettingsUI/Account/Backup/Protocols/BackupPasswordValidator.swift
Outdated
Show resolved
Hide resolved
WireUI/Sources/WireSettingsUI/Resources/en.lproj/Accessibility.strings
Outdated
Show resolved
Hide resolved
WireUI/Sources/WireSettingsUI/Resources/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Settings/Backup/BackupPasswordValidator.swift
Show resolved
Hide resolved
El-Fitz
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I've left a few comments, but nothing blocking.
WireUI/Sources/WireSettingsUI/Account/Backup/ViewModels/BackupActionsViewModel.swift
Outdated
Show resolved
Hide resolved
WireUI/Sources/WireSettingsUI/Account/Backup/Views/ExportBackupView.swift
Outdated
Show resolved
Hide resolved
WireUI/Sources/WireSettingsUI/Account/Backup/Views/PasswordFieldView.swift
Outdated
Show resolved
Hide resolved
caldrian
reviewed
Jan 9, 2025
caldrian
reviewed
Jan 9, 2025
wire-ios-data-model/Source/ManagedObjectContext/CoreDataStack+Backup.swift
Show resolved
Hide resolved
caldrian
approved these changes
Jan 9, 2025
KaterinaWire
changed the base branch from
develop
to
epic/prepare-for-universal-backups-WPB-14616
January 10, 2025 15:12
KaterinaWire
changed the base branch from
epic/prepare-for-universal-backups-WPB-14616
to
develop
January 10, 2025 15:13
KaterinaWire
changed the base branch from
develop
to
epic/prepare-for-universal-backups-WPB-14616
January 10, 2025 15:13
caldrian
force-pushed
the
feat/new-backup-export-UI-WPB-15211
branch
from
January 14, 2025 08:44
bfc722c
to
2357e37
Compare
caldrian
force-pushed
the
feat/new-backup-export-UI-WPB-15211
branch
from
January 14, 2025 08:44
2357e37
to
1e134af
Compare
caldrian
merged commit Jan 14, 2025
3997dcf
into
epic/prepare-for-universal-backups-WPB-14616
12 of 13 checks passed
6 tasks
echoes-hq
bot
added
the
echoes: product-roadmap/feature
Work contributing to adding a new feature as part of the product roadmap.
label
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap/feature
Work contributing to adding a new feature as part of the product roadmap.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In preparation for cross-platform backup, we need to update the UI for exporting a backup. This PR contains 2 major changes.
Old:
New:
Design
Note: the following PR will contain a backup restore from the Settings logic.
Additional improvements:
backupActiveAccount()
method from theSessionManager
and all the connected methods. I simplified the code by removing completion handlers and aligns with throwable and synchronous method design patterns.Testing
Settings -> Account -> Backup or Restore -> Backup now
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: