Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New export backup UI - WPB-15211 #2339

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Jan 3, 2025

Issue

In preparation for cross-platform backup, we need to update the UI for exporting a backup. This PR contains 2 major changes.

  1. Password for backup export is now Optional.
  2. The UI for exporting backup:
    Old:
Screenshot 2025-01-03 at 10 29 09

New:
Screenshot 2025-01-03 at 10 25 57

Design

Note: the following PR will contain a backup restore from the Settings logic.

Additional improvements:

  1. Refactoring backupActiveAccount() method from the SessionManager and all the connected methods. I simplified the code by removing completion handlers and aligns with throwable and synchronous method design patterns.
  2. All the new logic is in the WireUI -> WireSettingsUI -> Account -> Backup
  3. Remove old code.

Testing

Settings -> Account -> Backup or Restore -> Backup now

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test Results

    4 files     13 suites   8m 48s ⏱️
5 619 tests 5 590 ✅ 29 💤 0 ❌
5 630 runs  5 601 ✅ 29 💤 0 ❌

Results for commit 1e134af.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire marked this pull request as ready for review January 3, 2025 17:11
@KaterinaWire KaterinaWire requested a review from caldrian January 7, 2025 16:45
Copy link
Contributor

@El-Fitz El-Fitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I've left a few comments, but nothing blocking.

@KaterinaWire KaterinaWire changed the base branch from develop to epic/prepare-for-universal-backups-WPB-14616 January 10, 2025 15:12
@KaterinaWire KaterinaWire changed the base branch from epic/prepare-for-universal-backups-WPB-14616 to develop January 10, 2025 15:13
@KaterinaWire KaterinaWire changed the base branch from develop to epic/prepare-for-universal-backups-WPB-14616 January 10, 2025 15:13
@caldrian caldrian marked this pull request as draft January 13, 2025 17:03
@caldrian caldrian marked this pull request as ready for review January 14, 2025 08:42
@caldrian caldrian force-pushed the feat/new-backup-export-UI-WPB-15211 branch from bfc722c to 2357e37 Compare January 14, 2025 08:44
@caldrian caldrian force-pushed the feat/new-backup-export-UI-WPB-15211 branch from 2357e37 to 1e134af Compare January 14, 2025 08:44
@caldrian caldrian merged commit 3997dcf into epic/prepare-for-universal-backups-WPB-14616 Jan 14, 2025
12 of 13 checks passed
@caldrian caldrian deleted the feat/new-backup-export-UI-WPB-15211 branch January 14, 2025 09:15
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants