-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable adding remote domain users - WPB-10789 #2177
Merged
KaterinaWire
merged 51 commits into
develop
from
feat/disable-adding-remote-domain-users-WPB-10789
Dec 9, 2024
Merged
feat: disable adding remote domain users - WPB-10789 #2177
KaterinaWire
merged 51 commits into
develop
from
feat/disable-adding-remote-domain-users-WPB-10789
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 16 files 17 suites 15m 33s ⏱️ Results for commit d6717a7. ♻️ This comment has been updated with latest results. |
netbe
reviewed
Nov 26, 2024
wire-ios-sync-engine/Source/Use cases/IsFederationSearchAllowedUseCase.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/Use cases/IsFederationSearchAllowedUseCase.swift
Outdated
Show resolved
Hide resolved
jullianm
reviewed
Nov 26, 2024
wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewModel.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
reviewed
Nov 27, 2024
wire-ios-sync-engine/Source/UserSession/Search/SearchRequest.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewController.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
reviewed
Dec 4, 2024
jullianm
reviewed
Dec 4, 2024
wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/SearchResultsViewController.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/SearchResultsViewController.swift
Show resolved
Hide resolved
jullianm
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
netbe
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes/initiative: federation-and-mls-on-wire-c...
Activate Federation with MLS on Wire Cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Filter search result depends on the protocol of the conversation:
Proteus
ConversationsProteus
is default protocol of the team.Solution
We need to add conditions to filter out federated users in different parts: add members, create conversation, search users, open 1:1. For this reason, I created
IsFederationSearchAllowedUseCase
, which contains these conditions:Also, soon we will need to extend these conditions with another one, which is necessary for one of the customers.
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: