Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable adding remote domain users - WPB-10789 #2177

Merged

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 21, 2024

StoryWPB-10789 [iOS] Disable adding remote domain users in Proteus Conversations

Issue

Filter search result depends on the protocol of the conversation:

  • disable adding remote domain users in Proteus Conversations
  • do not show users from other domains in the conversation creation interface when Proteus is default protocol of the team.

Solution

We need to add conditions to filter out federated users in different parts: add members, create conversation, search users, open 1:1. For this reason, I created IsFederationSearchAllowedUseCase, which contains these conditions:

  • if the protocol of a conversation is Proteus, do not show users from other domains in the interface to add users;
  • if Proteus is the default protocol of the team, do not show users from other domains in the conversation creation interface.

Also, soon we will need to extend these conditions with another one, which is necessary for one of the customers.

Testing

  1. Create Proteus conversation.
  2. Try to add users with other domain.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes/initiative: federation-and-mls-on-wire-c... Activate Federation with MLS on Wire Cloud label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

   16 files     17 suites   15m 33s ⏱️
8 427 tests 8 396 ✅ 31 💤 0 ❌
8 448 runs  8 417 ✅ 31 💤 0 ❌

Results for commit d6717a7.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire marked this pull request as ready for review November 22, 2024 08:34
@KaterinaWire KaterinaWire requested a review from netbe November 25, 2024 10:26
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@KaterinaWire KaterinaWire added this pull request to the merge queue Dec 9, 2024
@KaterinaWire KaterinaWire removed this pull request from the merge queue due to a manual request Dec 9, 2024
@KaterinaWire KaterinaWire added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit 80d487c Dec 9, 2024
28 checks passed
@KaterinaWire KaterinaWire deleted the feat/disable-adding-remote-domain-users-WPB-10789 branch December 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-and-mls-on-wire-c... Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants