Skip to content

feat: Clients should initialize MLS clients according to backend feature flag - WPB-10118 #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Nov 27, 2024

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 5, 2024

Issue

All clients need to register an MLS client by only doing so when the following conditions are fulfilled:

  • GET /mls/public-keys contains an entry with the key removal. As a "defensive programming" we can check if there is at least one non-nil and non-empty key.
  • The mls feature config is enabled (status = enabled)

The DeveloperFlag.enableMLSSupport flag should also be removed, since the source of feature status should be feature config.

Needs to release with:

  • [https://github.com/wireapp/wire-ios-build-assets/pull/130]

Testing


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

   11 files    976 suites   13m 17s ⏱️
7 818 tests 7 818 ✅ 0 💤 0 ❌
7 837 runs  7 837 ✅ 0 💤 0 ❌

Results for commit 75a30e0.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire changed the title feat: Clients should initialize MLS clients according to backend feature flag feat: Clients should initialize MLS clients according to backend feature flag - WPB-10118 Nov 7, 2024
@KaterinaWire KaterinaWire marked this pull request as ready for review November 7, 2024 08:44
Copy link
Collaborator

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding GetMLSFeatureUseCase, it doesn't really feel like a use case to me. A use case, I would argue, is some public API for the presentation layer to invoke. Instead, getting the MLS feature config is already provided by the feature repository, so why is this extra layer needed?

@KaterinaWire KaterinaWire added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 8387d2b Nov 27, 2024
12 checks passed
@KaterinaWire KaterinaWire deleted the feat/init-mls-clients-according-to-be-WPB-10118 branch November 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-and-mls-on-wire-c... Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants