-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Clients should initialize MLS clients according to backend feature flag - WPB-10118 #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clients should initialize MLS clients according to backend feature flag - WPB-10118 #2129
Conversation
Test Results 11 files 976 suites 13m 17s ⏱️ Results for commit 75a30e0. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding GetMLSFeatureUseCase
, it doesn't really feel like a use case to me. A use case, I would argue, is some public API for the presentation layer to invoke. Instead, getting the MLS feature config is already provided by the feature repository, so why is this extra layer needed?
...Domain/Tests/WireDomainTests/Event Processing/UserEventProcessor/OneOnOneResolverTests.swift
Outdated
Show resolved
Hide resolved
wire-ios-request-strategy/Sources/Payloads/Processing/ConversationEventPayloadProcessor.swift
Outdated
Show resolved
Hide resolved
...quest-strategy/Sources/Request Strategies/MLS/FetchBackendMLSPublicKeysRequestStrategy.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMClientRegistrationStatus.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: John Nguyen <[email protected]>
Co-authored-by: John Nguyen <[email protected]>
Issue
All clients need to register an MLS client by only doing so when the following conditions are fulfilled:
GET /mls/public-keys
contains an entry with the key removal. As a "defensive programming" we can check if there is at least one non-nil and non-empty key.mls
feature config is enabled (status = enabled)The
DeveloperFlag.enableMLSSupport
flag should also be removed, since the source of feature status should be feature config.Needs to release with:
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: