Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key package query time - WPB-11882 #1860

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

David-Henner
Copy link
Contributor

@David-Henner David-Henner commented Aug 28, 2024

TaskWPB-11882 MLS key package query time

Issue

As per this use case we need to set the date of the last time the key package count has been queried to only query the key package count every 24h or more.

However, we're only setting the date after this guard

guard unclaimedKeyPackageCount <= halfOfTargetUnclaimedKeyPackageCount else {
  logger.info("no need to upload new key packages yet")
  return
}

So if the key package count is greater than half of the target count, then we risk querying the key package count several times in 24h, which goes against what was defined in the use case.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@johnxnguyen johnxnguyen marked this pull request as ready for review September 20, 2024 08:14
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Results

    1 files    255 suites   5m 12s ⏱️
2 411 tests 2 410 ✅ 0 💤 1 ❌
2 413 runs  2 410 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit e1e28df.

♻️ This comment has been updated with latest results.

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Oct 24, 2024
@netbe netbe changed the title fix: key package query time - no ticket fix: key package query time - WPB-11882 Oct 28, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants