Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avs_pc: add wasm source map so avs debugging in chrome is possible #72

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

EnricoSchw
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR adds a new option to create a WASM. This creates a source map and allows you to debug the AVS C code in the browser. It is a simple implementation. For More information i add a documentation file:

Issues

It is difficult to understand the behavior of the AVS Lib without a debugging infos in the browser.

Causes (Optional)

I debug how c objects work together with JS objects.

Solutions

Create a WASM with Debugging infos.

Pease check: README IN DOC

How to Test

Pease check: README IN DOC


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@EnricoSchw EnricoSchw self-assigned this Jun 18, 2024
@EnricoSchw EnricoSchw requested a review from a team as a code owner June 18, 2024 16:36
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@z-dule
Copy link
Contributor

z-dule commented Jul 1, 2024

This looks good to me.

@z-dule z-dule merged commit 2c782f1 into main Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants