Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Nov 17, 2025

TaskWPB-21762 [Android]Deleted image file can be viewed in conversation

https://wearezeta.atlassian.net/browse/WPB-21762

What's new in this PR?

Issues

Deleted image is correctly shown as "File not available" in conversation but can still be viewed by clicking on it.

Causes (Optional)

File status is not checked when image is clicked.

Solutions

Check file status correctly, add unit test.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.66%. Comparing base (6b42102) to head (c62f179).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4420      +/-   ##
===========================================
+ Coverage    47.42%   47.66%   +0.24%     
===========================================
  Files          537      537              
  Lines        18000    18002       +2     
  Branches      3048     3050       +2     
===========================================
+ Hits          8536     8581      +45     
+ Misses        8549     8497      -52     
- Partials       915      924       +9     
Files with missing lines Coverage Δ
...messagetypes/multipart/MultipartAttachmentsView.kt 0.00% <ø> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 62.50% <100.00%> (+62.50%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b42102...c62f179. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov force-pushed the fix/cell-deleted-image-open branch from fbf58c6 to 63a3bf4 Compare November 17, 2025 11:30
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 17, 2025
@sonarqubecloud
Copy link

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Nov 19, 2025
Merged via the queue into develop with commit 809cfda Nov 19, 2025
15 of 16 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/cell-deleted-image-open branch November 19, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants