Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recreate cache directories in case cache is cleared [WPB-7368] #3013

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 17, 2024

BugWPB-7368 [Android] Playstore crash - Resample Image and File handling


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We get multiple crashes when accessing cache files (ENOENT errors) which potentially suggest that the cache is fully cleared and the app cannot find needed directories for the given user in cache to create a temporary file for that user.

Solutions

Refactor code to have only single source of temporary file paths - kaliumFileSystem.tempFilePath, and use updated kalium version where cache directories are being recreated when getting a temporary cache file path in case cache is cleared.

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Open the app, clear app cache and try to send or download asset.

Notes (Optional)

Specify here any other facts that you think are important for this issue.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Test Results

927 tests   927 ✅  9m 12s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 39ef6da.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, MohamadJaara, Garzas and ohassine and removed request for a team May 17, 2024 12:47
@AndroidBob
Copy link
Collaborator

Build 4798 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 74e655c into release/candidate May 20, 2024
15 checks passed
@saleniuk saleniuk deleted the fix/recreate-cache-directories-when-cleared branch May 20, 2024 08:33
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Jul 16, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants