chore(conversation-history): serialize history client messages [WPB-18414] [WPB-18416] #3569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
Garzas,
MohamadJaara,
Copilot,
ohassine and
sbakhtiarov
There was a problem hiding this comment.
Pull Request Overview
This PR adds serialization and deserialization support for History-Client messages in the protobuf system. The implementation introduces three new message types for history client management and updates the codebase to handle these messages throughout the system.
Key changes:
- Adds protobuf definitions for three new history client message types (Available, Request, Response)
- Moves HistoryClient class from conversation-history module to data module for broader accessibility
- Implements serialization/deserialization logic in ProtoContentMapper with TODO placeholder for message handling
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| protobuf-codegen/src/main/proto/messages.proto | Adds protobuf definitions for HistoryClient messages |
| logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/ProtoContentMapper.kt | Implements serialization/deserialization for history client messages |
| data/src/commonMain/kotlin/com/wire/kalium/logic/data/history/HistoryClient.kt | Moves and refactors HistoryClient class, removing conversationId field |
| persistence/src/commonMain/db_user/com/wire/kalium/persistence/HistoryClient.sq | Updates SQL queries to exclude conversation_id field |
| Multiple files | Updates imports and adds message content types for history client messages |
data/src/commonMain/kotlin/com/wire/kalium/logic/data/message/Message.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/wire/kalium/logic/sync/receiver/conversation/message/ApplicationMessageHandler.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3569 +/- ##
=============================================
- Coverage 49.90% 49.84% -0.07%
+ Complexity 51 46 -5
=============================================
Files 1707 1709 +2
Lines 63844 64083 +239
Branches 5615 5653 +38
=============================================
+ Hits 31862 31942 +80
- Misses 29808 29959 +151
- Partials 2174 2182 +8
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Bencher Report| Branch | conversation-history/chore/serialize-messages |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 684.96 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 454,234.45 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,478,545.57 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 28,700.68 µs |
Garzas
approved these changes
Aug 8, 2025
data/src/commonMain/kotlin/com/wire/kalium/logic/data/message/Message.kt
Outdated
Show resolved
Hide resolved
ohassine
approved these changes
Aug 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
vitorhugods
force-pushed
the
conversation-history/chore/serialize-messages
branch
from
adb2105 to
bd897ee
Compare
vitorhugods
force-pushed
the
conversation-history/chore/serialize-messages
branch
from
bd897ee to
d9769a0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Add (de)serialization for History-Client messages.
Note
HistoryClientclass to the:datamodule, as it is also gonna be part of the messages.TODOfor handling the new message types. The handled is gonna be implemented in:conversation-history.Important
The protobuf messages are also being updated in the generic-message-proto repo:
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.