Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FederatedSearchParser accept if other domain allowed [WPB-10788] #3004

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Sep 10, 2024

StoryWPB-10788 [Android] Disable adding remote domain users in Proteus Conversations

What's new in this PR?

Issues

We need to disable adding users with another domain to add into Preteus conversations and in Proteus teams.

Solutions

The best place to do it is FederatedSearchParser with parse search query and split it into searchQuery and Domain.
So i've added a isOtherDomainAllowed flag there, if it's true other domain allowed and query parsed as usual; if it's false - current users domain is used.

Also added GetConversationProtocolInfoUseCase and tests for it for getting Conversations ProtocolInfo in Android side.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Test Results

3 200 tests  +3   3 095 ✔️ +3   4m 4s ⏱️ +33s
   551 suites +1      105 💤 ±0 
   551 files   +1          0 ±0 

Results for commit d3e3c83. ± Comparison against base commit 7f991e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

🐰Bencher

ReportThu, September 12, 2024 at 14:46:56 UTC
Projectkalium
Branchfeat/federated_search_parser_accept_if_other_domain_allowed
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)691,930.05
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)401,599,394.67
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)937,911,144.89
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,966,537.47

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (7f991e6) to head (d3e3c83).

Files with missing lines Patch % Lines
...conversation/GetConversationProtocolInfoUseCase.kt 83.33% 2 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3004      +/-   ##
===========================================
- Coverage    52.52%   52.52%   -0.01%     
===========================================
  Files         1299     1300       +1     
  Lines        49953    49966      +13     
  Branches      4655     4655              
===========================================
+ Hits         26238    26243       +5     
- Misses       21835    21842       +7     
- Partials      1880     1881       +1     
Files with missing lines Coverage Δ
...lium/logic/feature/search/FederatedSearchParser.kt 92.30% <100.00%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...conversation/GetConversationProtocolInfoUseCase.kt 83.33% <83.33%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f991e6...d3e3c83. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 10, 2024

Datadog Report

Branch report: feat/federated_search_parser_accept_if_other_domain_allowed
Commit report: 7eb4cca
Test service: kalium-jvm

✅ 0 Failed, 3095 Passed, 105 Skipped, 17.4s Total Time

Copy link

sonarcloud bot commented Sep 12, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit 85e5c25 Sep 16, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the feat/federated_search_parser_accept_if_other_domain_allowed branch September 16, 2024 09:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants