-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FederatedSearchParser accept if other domain allowed [WPB-10788] #3004
feat: FederatedSearchParser accept if other domain allowed [WPB-10788] #3004
Conversation
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3004 +/- ##
===========================================
- Coverage 52.52% 52.52% -0.01%
===========================================
Files 1299 1300 +1
Lines 49953 49966 +13
Branches 4655 4655
===========================================
+ Hits 26238 26243 +5
- Misses 21835 21842 +7
- Partials 1880 1881 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3095 Passed, 105 Skipped, 17.4s Total Time |
…her_domain_allowed
Quality Gate passedIssues Measures |
What's new in this PR?
Issues
We need to disable adding users with another domain to add into Preteus conversations and in Proteus teams.
Solutions
The best place to do it is
FederatedSearchParser
with parse search query and split it into searchQuery and Domain.So i've added a
isOtherDomainAllowed
flag there, if it's true other domain allowed and query parsed as usual; if it's false - current users domain is used.Also added
GetConversationProtocolInfoUseCase
and tests for it for getting Conversations ProtocolInfo in Android side.