perf: improve ProteusClientCoreCrypto performance [WPB-10000]

[vitorhugods]

WPB-10000 [Android] Investigate the text last read event handling bottleneck and spickes

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

We're a bit slow to process events.

Causes

In part, it's nature of E2EE. In part, we are not really being optimal.

In the generic sense, we can improve Proteus/CoreCrypto performance by not saving session (which is unnecessary, as CoreCrypto already does it during decryption), and also avoid checking if the session exists over and over again if we already know it exists.

Solutions

1. Remove the "saveSession" bit of ProteusClientCoreCrypto.
2. Cache known sessions in-memory and check that instead of relying only on CoreCrypto, which uses IO in order to do that

Document my findings in this notebook.

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 193 tests  ±0   3 088 ✔️ ±0   3m 39s ⏱️ +2s
   548 suites ±0      105 💤 ±0 
   548 files   ±0          0 ❌ ±0 

Results for commit 7c291a0. ± Comparison against base commit 938fee7.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: perf/improve-event-processing-speed
Commit report: 16dff6a
Test service: kalium-jvm

✅ 0 Failed, 3088 Passed, 105 Skipped, 12.86s Total Time

[MohamadJaara]

this change is a nice candidate for a ADR, just saying it does not need to be the whole notebook, but maybe small description with a link to the notebook

[yamilmedina]

Great work and nice introduction of these notebooks
Just left one suggestion/question about naming and breaking patterns.

Also agree with Mo, this is a good candidate for an ADR, maybe for a next PR 🤔

[vitorhugods]

Great work and nice introduction of these notebooks Just left one suggestion/question about naming and breaking patterns.

Also agree with Mo, this is a good candidate for an ADR, maybe for a next PR 🤔

About ADRs... do we have ADRs on Kalium as well? Because this was the main reason that made me not do it. I am starting to think we should merge the repos more and more.

---

I just did Notebooks instead of notebooks because it is indeed different from the rest. Maybe docs would be better. I'll rename it to something like that.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud