chore: Improve isSelfATeamMember UseCase (WPB-8978) #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore returning default false value for isSelfATeamMember
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
alexandreferris
requested review from
a team,
yamilmedina,
borichellow,
vitorhugods,
ohassine,
saleniuk and
Garzas
and removed request for
a team
vitorhugods
approved these changes
Aug 1, 2024
|
| Report | Thu, August 1, 2024 at 09:46:18 UTC |
| Project | kalium |
| Branch | chore/improve_isSelfATeamMember |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | ➖ (view plot) | 694,644.42 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | ➖ (view plot) | 610,903,047.32 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | ➖ (view plot) | 928,381,990.31 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | ➖ (view plot) | 21,525,544.53 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Datadog ReportBranch report: ✅ 0 Failed, 3039 Passed, 105 Skipped, 13.23s Total Time |
borichellow
approved these changes
Aug 1, 2024
5 tasks
alexandreferris
added a commit
that referenced
this pull request
Aug 1, 2024
* chore: add slow sync repository to observe for last sync completion before returning default false value for isSelfATeamMember * chore: add parameter for SlowSyncRepository for new usage * tests: adjust existing tests for the usecase (cherry picked from commit 9dbf5f5)
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat: Add Anonymous Analytics User Profile EPIC - (WPB-8978) (#2887) * feat: add analytics user profile - Part 1 (WPB-8978) (#2868) * feat: add method to set/insert tracking identifier into user metadata table * feat: add MessageContent for DataTransfer with TrackingIdentifier * feat: add DataTransferEventHandler to handle new data transfer events and set tracking identifier to user config metadata * chore: remove needless blank line * feat: add analytics user profile - Part 2 (WPB-8978) (#2877) * feat: add method to set/insert tracking identifier into user metadata table * feat: add MessageContent for DataTransfer with TrackingIdentifier * feat: add DataTransferEventHandler to handle new data transfer events and set tracking identifier to user config metadata * chore: remove needless blank line * feat: add get for current tracking identifier and get and set for previous tracking identifier * feat: add usage and logic handling for current and previous tracking identifiers * feat: add tests * feat: add better handling of receiving already existing tracking id and tests * feat: add new analytics logger to kalium logger * feat: add usecase to observe analytics tracking identifier * feat: add tests for observeAnalyticsTrackingIdentifierStatus * feat: add none AnalyticsIdentifierResult to be used in AR and remove abstract attribute * feat: add proper mapping to observer result and verification on Either Left is tracking identifier already exists * feat: add tests for observer with new logic * chore: add user scope logger * chore: add `as` instantiation of right value for usecase result * feat: move AnalyticsIdentifierResult to new data module and update its usages * feat: add usecase to delete previous tracking identifier * chore: add missing imports * test: add test for DeletePreviousTrackingIdentifierUseCase * chore: remove delete previous tracking identifier use case * feat: add extra sealed interface for better handling of analytics identifier result * feat: add AnalyticsIdentifierManager to handle migration complete and propagating tracking identifier * chore: add missing extension from new sealed interface * test: add tests for AnalyticsIdentifierManager * chore: adjust detekt * chore: remove unused import * chore: rename user config current tracking identifier * chore: add docs (cherry picked from commit f534d36) * feat: Add packing and sending DataTransfer message - (WPB-8978) (#2896) * feat: add syncManager to AnalyticsIdentifierManager in order to wait for current device to be available * feat: add implementation of packDataTransfer message * test: add tests (cherry picked from commit 337c415) * chore: Improve isSelfATeamMember UseCase (WPB-8978) (#2924) * chore: add slow sync repository to observe for last sync completion before returning default false value for isSelfATeamMember * chore: add parameter for SlowSyncRepository for new usage * tests: adjust existing tests for the usecase (cherry picked from commit 9dbf5f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When first trying to get if self user is a team member, it would return the default(false) value if sync was not done before.
Causes (Optional)
Sync was not done prior to the retrieval of this value.
Solutions
Add SlowSyncRepository and observe last sync complete before returning a value, so it will now always get the correct value for the user.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Everything should continue running as is.