Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add analytics user profile - Part 2 (WPB-8978) #2877
feat: add analytics user profile - Part 2 (WPB-8978) #2877
Changes from 12 commits
7ba6c47
27c8163
27b9220
c2a1105
e05e102
46d744f
43db0b6
cf4cb58
89e8824
91772f5
6bed9be
1748248
ec1d55d
9887094
efb3ed5
bdd660c
217d216
cfbc9b2
1e16b82
41066e2
495e142
1273307
5f03b4d
57b3670
669aa7d
1cf6287
34a3839
00050ba
a466cfa
96c5280
7a96b8b
f4f34e5
0c68003
35144c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the
previousTrackingIdentifier
, how does it compare withgetTrackingIdentifier
?Every time we
setTrackingIdentifier(N)
wesetPreviousTrackingIdentifier(N-1)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we set the
PreviouTrackingIdentifier
when we receive a newTrackingIdentifier
from remote (meaning a new device of the user was logged in somewhere else and we now need to use this new tracking identifier).Both identifiers are kept until a proper analytics migration of the new identifier is done, then the previous identifier is deleted.