feat: Update isReplyAllowed in Notifications according LegalHoldStatus [WPB-7425] #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
122
to
125
| val isReplyAllowed = messages.first().run { | ||
| degradedConversationNotified | ||
| && (legalHoldStatus == ConversationEntity.LegalHoldStatus.ENABLED && !legalHoldStatusChangeNotified) | ||
| } |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.6 #2874 +/- ##
============================================================
Coverage ? 58.42%
Complexity ? 7
============================================================
Files ? 1185
Lines ? 46650
Branches ? 4432
============================================================
Hits ? 27256
Misses ? 17411
Partials ? 1983
Continue to review full report in Codecov by Sentry.
|
yamilmedina
approved these changes
Jul 15, 2024
MohamadJaara
approved these changes
Jul 15, 2024
MohamadJaara
deleted the
feat/update_is_reply_allowed_in_notifications_according_legal_hold_status
branch
echoes-hq
bot
added
the
echoes: bugs
b1pb1p
added
echoes: features
7 tasks
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When LegalHold activated and user was not notified about it, we need to disable "Reply" feature for notifications.
Causes (Optional)
Wasn't implemented
Solutions
Implement it.