Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add isReplyAllowed field to notification entity [WPB-7425] 🍒 #2871

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 10, 2024

BugWPB-7425 [Android] Replying from notification to degraded conversation

This PR was automatically cherry-picked based on the following PR:

Original PR description:


What's new in this PR?

Issues

Need to remove option "Reply" from the notifications in conversations that has Degraded verification status.

Causes (Optional)

Wasn't implemented yet.

Solutions

Update DB-query to get also Conversation.degradedConversationNotified while getting notifications and use it as isReplyAllowed flag in creating OS-notifications.

import com.wire.kalium.logic.functional.map
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor Author

github-actions bot commented Jul 10, 2024

Test Results

3 073 tests   2 968 ✔️  3m 23s ⏱️
   530 suites     105 💤
   530 files           0

Results for commit be16f45.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 10, 2024

Datadog Report

Branch report: feat/add_is_replay_allowed_field_to_notification_entity-cherry-pick
Commit report: 4d0d74c
Test service: kalium-jvm

✅ 0 Failed, 2968 Passed, 105 Skipped, 12.24s Total Time

Copy link

sonarcloud bot commented Jul 10, 2024

@borichellow borichellow merged commit 7756d06 into release/candidate Jul 11, 2024
19 checks passed
@borichellow borichellow deleted the feat/add_is_replay_allowed_field_to_notification_entity-cherry-pick branch July 11, 2024 08:53
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Jul 16, 2024
@b1pb1p b1pb1p added echoes: features End-user visible changes intended to create customer value and removed echoes: bugs Technical or functional defects in the product labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants