fix: Split NoCommonProtocol error #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
typfel,
yamilmedina,
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Garzas
approved these changes
Jun 24, 2024
vitorhugods
approved these changes
Jun 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
* fix: Split NoCommonProtocol error * Fixed style
vitorhugods
pushed a commit
that referenced
this pull request
Jun 25, 2024
* fix: Split NoCommonProtocol error * Fixed style Co-authored-by: boris <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jun 25, 2024
* fix: Split NoCommonProtocol error * Fixed style Co-authored-by: boris <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* fix: Split NoCommonProtocol error (#2832) (#2834) * fix: Split NoCommonProtocol error * Fixed style Co-authored-by: boris <[email protected]> * chore: empty commit bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: yamilmedina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
For displaying correct error message in UI we need to split
NoCommonProtocolerror intoSelfNeedToUpdatemeans current client is old, doesn't support MLS and needs to updateOtherNeedToUpdatemeans other user (that we are trying to communicate) has old version, doesn't support MLS and needs to update.Causes (Optional)
Was not implemented, was not needed
Solutions
Just do it. 💪
and update tests