fix: Wrong E2EI information for other users [WPB-9409] #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
mchenani
reviewed
Jun 20, 2024
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Conversations.sq
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
mchenani
approved these changes
Jun 21, 2024
yamilmedina
approved these changes
Jun 21, 2024
…ion_for_other_users
|
MohamadJaara
approved these changes
Jun 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
* fix: Wrong E2EI information for other users * Added tests
vitorhugods
pushed a commit
that referenced
this pull request
Jul 2, 2024
* fix: Wrong E2EI information for other users [WPB-9409] (#2828) * fix: Wrong E2EI information for other users * Added tests * Empty-Commit --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
Wrong e2ei information for other users after self user is kicked out of the group:
Result:
device for user A does not have cert information
Causes (Optional)
To get Identities for each device of user we need to get Id of MLS group this users belongs to.
To get MLS group kalium finds the conversation that this user belongs to and get MLSGroupId from it.
The problem comes out when self user is removed from some group-conversation and when kalium is looking for conversation OtherUser belongs to, finds exactly that group-conversation (it happens not in 100% of cases as there are couple of such conversations in DB, but
LIMIT 1in query is used). So kalium uses MLSGroupId of the conversation SelfUser doesn't belongs to => doesn't have access to MLS group => no Identities found for OtherUser.Solutions
Update DB-query to get MLSGpoupId of conversation that both (SelfUser and OtherUser) belongs to.