feat: CRL proxy [WPB-8793] 🍒 #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
borichellow
approved these changes
Jun 7, 2024
MohamadJaara
approved these changes
Jun 7, 2024
vitorhugods
reviewed
Jun 7, 2024
...commonTest/kotlin/com/wire/kalium/logic/data/e2ei/CertificateRevocationListRepositoryTest.kt
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 2958 Passed, 105 Skipped, 11.82s Total Time |
|
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2024
* Commit with unresolved merge conflicts * Resolve problems after cherry-pick * Fix code-style --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
MohamadJaara
pushed a commit
that referenced
this pull request
Jul 12, 2024
* feat: CRL proxy [WPB-8793] 🍒 (#2802) * Commit with unresolved merge conflicts * Resolve problems after cherry-pick * Fix code-style --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]> * Fixed build --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
The web/desktop frontend use a proxy to fetch CRLs from other domains. However Android clients fetch those CRLs directly.
Causes (Optional)
It was implemented like this.
Solutions
Implement usage of proxy url for fetching CRLs when it's required and available.