Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete zip dummy file from test resources #2793

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

fdroid does not allow the repo to have zip files

Solutions

nuke it

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Signed-off-by: MohamadJaara <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test Results

2 923 tests   2 905 ✔️  4m 49s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit c0343f9.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jun 3, 2024

Datadog Report

Branch report: chore/fdroid-build-changes
Commit report: ca94284
Test service: kalium-jvm

✅ 0 Failed, 2954 Passed, 105 Skipped, 9.15s Total Time

@MohamadJaara MohamadJaara enabled auto-merge (squash) June 3, 2024 07:59
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've added a dummy pdf file as well :D

@MohamadJaara
Copy link
Member Author

MohamadJaara commented Jun 4, 2024

Could've added a dummy pdf file as well :D

there is already one 😅

@MohamadJaara MohamadJaara merged commit e653caf into release/candidate Jun 5, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the chore/fdroid-build-changes branch June 5, 2024 18:26
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
* remove zip file from test resources

* Trigger CI

Signed-off-by: MohamadJaara <[email protected]>

---------

Signed-off-by: MohamadJaara <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jun 6, 2024
* remove zip file from test resources

* Trigger CI



---------

Signed-off-by: MohamadJaara <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants