Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused WireCryptobox binaries #2792

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

delete unused WireCryptobox bindings

Needs releases with:

  • GitHub link to other pull request

Testing

iOS test should pass

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove Cartfile and Cartfile.resolved they are also related to Carthage.

@MohamadJaara MohamadJaara requested a review from typfel May 31, 2024 15:52
@datadog-wireapp
Copy link

datadog-wireapp bot commented May 31, 2024

Datadog Report

Branch report: chore/delete-unused-WireCryptobox-apple-binaries
Commit report: a20efd3
Test service: kalium-jvm

❌ 1 Failed (0 Known Flaky), 2919 Passed, 52 Skipped, 11.38s Total Time

❌ Failed Tests (1)

  • givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected[jvm] - com.wire.kalium.persistence.dao.message.MessageNotificationsTest - Details

    Expand for error
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     	at app//app.cash.turbine.TurbineAssertionError$Companion.invoke(TurbineAssertionError.kt:32)
     	at app//app.cash.turbine.ChannelTurbine.ensureAllEventsConsumed(Turbine.kt:235)
     	at app//app.cash.turbine.TurbineTestContextImpl.ensureAllEventsConsumed(flow.kt)
     	at app//com.wire.kalium.persistence.dao.message.MessageNotificationsTest$givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected$1$1.invokeSuspend(MessageNotificationsTest.kt:74)
     	at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
     ...
    

@MohamadJaara MohamadJaara changed the title chore: delete unused WireCryptobox bindings chore: delete unused WireCryptobox binaries May 31, 2024
Copy link
Contributor

github-actions bot commented May 31, 2024

Test Results

3 059 tests   2 954 ✔️  3m 25s ⏱️
   530 suites     105 💤
   530 files           0

Results for commit b9ef87f.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge (squash) June 3, 2024 07:59
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MohamadJaara MohamadJaara merged commit a56af40 into release/candidate Jun 3, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the chore/delete-unused-WireCryptobox-apple-binaries branch June 3, 2024 11:03
github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
* chore: delete unused WireCryptobox bindings

* address PR comments
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
* chore: delete unused WireCryptobox bindings

* address PR comments

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants