Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused libsodium binaries #2791

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

delete unused libsodium bindings

Needs releases with:

  • GitHub link to other pull request

Testing

build app without cache and encrypted proteus storage disabled -> app works

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 31, 2024

Test Results

3 059 tests   2 954 ✔️  3m 8s ⏱️
   530 suites     105 💤
   530 files           0

Results for commit fc96ce4.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/delete-unused-libsodium-bindings
Commit report: 5977bf5
Test service: kalium-jvm

✅ 0 Failed, 2954 Passed, 105 Skipped, 9.22s Total Time

@MohamadJaara MohamadJaara changed the title chore: delete unused libsodium bindings chore: delete unused libsodium binaries May 31, 2024
@MohamadJaara MohamadJaara merged commit a9e1741 into release/candidate Jun 3, 2024
23 checks passed
@MohamadJaara MohamadJaara deleted the chore/delete-unused-libsodium-bindings branch June 3, 2024 07:59
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants