fix(mls): update migrated conversation with correct group id and cipher suites (WPB-9169) 🍒 #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: M
🚨 Potential breaking changes
labels
…into fix/mls-migration-cs-cherry-pick
…' into fix/mls-migration-cs-cherry-pick
Datadog ReportBranch report: ✅ 0 Failed, 2954 Passed, 105 Skipped, 11.78s Total Time |
|
Garzas
approved these changes
May 27, 2024
github-actions bot
added a commit
that referenced
this pull request
May 27, 2024
…er suites (WPB-9169) 🍒 (#2771) * Commit with unresolved merge conflicts * Commit with unresolved merge conflicts * trigger CI * fix tests to match candidate changes * fix tests --------- Co-authored-by: Mojtaba Chenani <[email protected]>
Merged
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…er suites (WPB-9169) 🍒 (#2771) (#2788) * Commit with unresolved merge conflicts * Commit with unresolved merge conflicts * trigger CI * fix tests to match candidate changes * fix tests --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
echoes-hq
bot
added
the
echoes: bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Set MLS groupId and correct cipher suite to the migrated conversation.
Issues
Due to changes to the ciphersuites we needed to cover rare and edge cases, also one missing part for persisting MLS groupId after receiving protocol updated event.
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.