fix(mls): respect default protocol in one-on-one conversation initialisation (WPB-8975) 🍒 #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: L
🚨 Potential breaking changes
labels
…-1on1-initialisation-cherry-pick
vitorhugods
reviewed
May 24, 2024
...src/commonTest/kotlin/com/wire/kalium/logic/feature/protocol/OneOnOneProtocolSelectorTest.kt
Outdated
Show resolved
Hide resolved
.../src/commonTest/kotlin/com/wire/kalium/logic/feature/mlsmigration/MLSMigrationManagerTest.kt
Outdated
Show resolved
Hide resolved
.../src/commonTest/kotlin/com/wire/kalium/logic/feature/mlsmigration/MLSMigrationManagerTest.kt
Outdated
Show resolved
Hide resolved
|
vitorhugods
approved these changes
May 24, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2954 Passed, 105 Skipped, 12.14s Total Time |
yamilmedina
approved these changes
May 24, 2024
yamilmedina
reviewed
May 24, 2024
| @@ -73,7 +73,7 @@ internal class MLSMigrationManagerImpl( | |||
| incrementalSyncRepository.incrementalSyncState.collect { syncState -> | |||
| ensureActive() | |||
| if (syncState is IncrementalSyncStatus.Live && | |||
| featureSupport.isMLSSupported && | |||
| isMLSEnabledUseCase() && | |||
There was a problem hiding this comment.
Suggested change
| isMLSEnabledUseCase() && | |
| isMLSEnabled() && |
Just a tiny change.
There was a problem hiding this comment.
Thanks for the note, I'm afraid if I change it now; then in other cherrypicks gonna create other issues!
mchenani
deleted the
fix/respect-default-protocol-in-1on1-initialisation-cherry-pick
branch
github-actions bot
added a commit
that referenced
this pull request
May 24, 2024
…isation (WPB-8975) 🍒 (#2769) * Commit with unresolved merge conflicts * trigger CI * fix tests to match candidate changes --------- Co-authored-by: Mojtaba Chenani <[email protected]>
Merged
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…isation (WPB-8975) 🍒 (#2769) (#2787) * Commit with unresolved merge conflicts * trigger CI * fix tests to match candidate changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
echoes-hq
bot
added
the
echoes: bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Causes (Optional)
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.