Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update AVS lib to 9.7.15 (WPB-9095) #2762

Merged
merged 1 commit into from
May 14, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented May 14, 2024

BugWPB-9095 [Android] Playstore crash - Audio sensor crash


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

AVS lib crashing when a Bluetooth device was disconnected but there was still a reference to it on audioManager getAvailableCommunicationDevices()

Solutions

Update AVS lib to 9.7.15 that is now handling nullable devices from getAvailableCommunicationDevices()

Copy link
Contributor

github-actions bot commented May 14, 2024

Test Results

3 039 tests   2 935 ✔️  3m 10s ⏱️
   528 suites     104 💤
   528 files           0

Results for commit a904a15.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 14, 2024

Datadog Report

Branch report: chore/update_avs_9_7_15
Commit report: 5ff20b8
Test service: kalium-jvm

✅ 0 Failed, 2935 Passed, 104 Skipped, 11.72s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected[jvm] - com.wire.kalium.persistence.dao.message.MessageNotificationsTest - Last Failure

    Expand for error
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     	at app//app.cash.turbine.TurbineAssertionError$Companion.invoke(TurbineAssertionError.kt:32)
     	at app//app.cash.turbine.ChannelTurbine.ensureAllEventsConsumed(Turbine.kt:235)
     	at app//app.cash.turbine.TurbineTestContextImpl.ensureAllEventsConsumed(flow.kt)
     	at app//com.wire.kalium.persistence.dao.message.MessageNotificationsTest$givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected$1$1.invokeSuspend(MessageNotificationsTest.kt:74)
     	at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
     ...
    

@alexandreferris alexandreferris merged commit fd90a9b into release/candidate May 14, 2024
19 checks passed
@alexandreferris alexandreferris deleted the chore/update_avs_9_7_15 branch May 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants