Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): crash on downloading certificates (WPB-9097) 🍒 #2761

Merged
merged 9 commits into from
May 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 14, 2024

BugWPB-9097 [Android] App crashing when viewing own or another users certificate

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adding serialisation annotation to serialisable classes.

Issues

Was missing for android navigation arguments.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor Author

github-actions bot commented May 24, 2024

Test Results

3 046 tests   2 941 ✔️  3m 13s ⏱️
   529 suites     105 💤
   529 files           0

Results for commit 93705d3.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/download-cert-cherry-pick
Commit report: 76a3278
Test service: kalium-jvm

✅ 0 Failed, 272 Passed, 13 Skipped, 3.22s Total Time

@tmspzz tmspzz enabled auto-merge (squash) May 24, 2024 13:10
@tmspzz tmspzz merged commit 0cdf629 into release/candidate May 24, 2024
19 checks passed
@tmspzz tmspzz deleted the fix/download-cert-cherry-pick branch May 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants