fix: No SystemMessage on new 1o1 conversation [WPB-8608] 🍒 #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
borichellow
approved these changes
May 14, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2936 Passed, 104 Skipped, 11.67s Total Time |
vitorhugods
approved these changes
May 15, 2024
…1-conversation-cherry-pick
|
borichellow
deleted the
fix/no-system-message-on-new-1o1-conversation-cherry-pick
branch
github-actions bot
added a commit
that referenced
this pull request
May 15, 2024
* Commit with unresolved merge conflicts * Fixed cherry-pick merging conflict --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
…2766) * Commit with unresolved merge conflicts * Fixed cherry-pick merging conflict --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
When user starts a new 1:1 conversation Android app shows a SystemMessage "You added User and you to the conversation", while there shouldn't be any message at all.
Causes (Optional)
MemberJoinEventHandlerhad the same implementation for 1:1 and group conversations.Solutions
In
MemberJoinEventHandleradd checking if the conversation is 1:1 then no need to add a new SystemMessage about new members.Also updated tests.