-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong failType for MLS federation errors [WPB-9087] #2757
Merged
saleniuk
merged 3 commits into
release/candidate
from
fix/wrong-failtype-for-mls-federation-errors
May 15, 2024
Merged
fix: wrong failType for MLS federation errors [WPB-9087] #2757
saleniuk
merged 3 commits into
release/candidate
from
fix/wrong-failtype-for-mls-federation-errors
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
May 13, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2937 Passed, 104 Skipped, 12.71s Total Time |
saleniuk
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
MohamadJaara and
vitorhugods
and removed request for
a team
May 14, 2024 06:10
alexandreferris
approved these changes
May 14, 2024
yamilmedina
approved these changes
May 14, 2024
Quality Gate passedIssues Measures |
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2024
* fix: wrong failType for MLS federation errors [WPB-9087] * detekt
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
* fix: wrong failType for MLS federation errors [WPB-9087] (#2757) * fix: wrong failType for MLS federation errors [WPB-9087] * detekt * trigger build --------- Co-authored-by: Michał Saleniuk <[email protected]> Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
"Learn more" links in conversation error message are not displayed anymore for MLS errors when creating a conversation and adding members.
Causes (Optional)
Wrong
failType
for MLS federation errors.Solutions
Set the right
failType
, also use correctfailType
for non-retryable errors.Testing
Test Coverage (Optional)
How to Test
STR:
Expected:
The error message should have a link “Learn more” which forwards the user to an FAQ page
Actual:
The “Learn more” link is missing.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.