Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong failType for MLS federation errors [WPB-9087] #2757

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 13, 2024

BugWPB-9087 [Android] Learn more links in conversation error message not displayed anymore


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

"Learn more" links in conversation error message are not displayed anymore for MLS errors when creating a conversation and adding members.

Causes (Optional)

Wrong failType for MLS federation errors.

Solutions

Set the right failType, also use correct failType for non-retryable errors.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

STR:

  • have users A and B from backend A
  • have user C from backend B
  • login as user A
  • start group creation flow, select user B and C
  • take user Cs backend offline
  • continue creating the group conversation
  • Error message is displayed about that user C could not be added

Expected:
The error message should have a link “Learn more” which forwards the user to an FAQ page

Actual:
The “Learn more” link is missing.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 13, 2024

Test Results

3 041 tests   2 937 ✔️  3m 24s ⏱️
   528 suites     104 💤
   528 files           0

Results for commit 024f572.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 13, 2024

Datadog Report

Branch report: fix/wrong-failtype-for-mls-federation-errors
Commit report: e740e6d
Test service: kalium-jvm

✅ 0 Failed, 2937 Passed, 104 Skipped, 12.71s Total Time

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and vitorhugods and removed request for a team May 14, 2024 06:10
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saleniuk saleniuk merged commit 8c6ee23 into release/candidate May 15, 2024
19 checks passed
@saleniuk saleniuk deleted the fix/wrong-failtype-for-mls-federation-errors branch May 15, 2024 15:22
github-actions bot pushed a commit that referenced this pull request May 15, 2024
* fix: wrong failType for MLS federation errors [WPB-9087]

* detekt
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2024
* fix: wrong failType for MLS federation errors [WPB-9087] (#2757)

* fix: wrong failType for MLS federation errors [WPB-9087]

* detekt

* trigger build

---------

Co-authored-by: Michał Saleniuk <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants