Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate execution of avsSyncStateReporter #2723

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

During a cherry pick we ended up calling avsSyncStateReporter.execute() twice from UserSessionScope

Causes (Optional)

This caused the Calling Manager to try to get the clientId before it was properly set on currentClientIdProvider

Solutions

Remove duplicate and only execute avsSyncStateReporter when clientId is set

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Test Results

3 038 tests  ±0   2 934 ✔️ ±0   3m 8s ⏱️ -20s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit bd3c684. ± Comparison against base commit bbf74b1.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/remove_duplicate_avsSyncStateReporter_execution
Commit report: dc5954d
Test service: kalium-jvm

✅ 0 Failed, 2934 Passed, 104 Skipped, 13m 56.04s Wall Time

@alexandreferris alexandreferris merged commit ede100f into release/candidate Apr 29, 2024
18 checks passed
@alexandreferris alexandreferris deleted the fix/remove_duplicate_avsSyncStateReporter_execution branch April 29, 2024 13:52
github-merge-queue bot pushed a commit that referenced this pull request Apr 29, 2024
* fix: remove duplicate execution of avsSyncStateReporter (#2723)

* empty trigger commit

---------

Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants