fix: remove duplicate execution of avsSyncStateReporter #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: XS
labels
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
vitorhugods
approved these changes
Apr 29, 2024
ohassine
approved these changes
Apr 29, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2934 Passed, 104 Skipped, 13m 56.04s Wall Time |
alexandreferris
deleted the
fix/remove_duplicate_avsSyncStateReporter_execution
branch
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* fix: remove duplicate execution of avsSyncStateReporter (#2723) * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
During a cherry pick we ended up calling
avsSyncStateReporter.execute()twice fromUserSessionScopeCauses (Optional)
This caused the Calling Manager to try to get the clientId before it was properly set on
currentClientIdProviderSolutions
Remove duplicate and only execute
avsSyncStateReporterwhen clientId is set